Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uml 3394 combined lpa manager #2782

Merged
merged 100 commits into from
Jan 20, 2025
Merged

Uml 3394 combined lpa manager #2782

merged 100 commits into from
Jan 20, 2025

Conversation

cooperaj
Copy link
Contributor

@cooperaj cooperaj commented Sep 17, 2024 •
edited
Loading

Purpose

Implement a combined LPA manager capable of retrieving LPA data from Sirius and Data Store.

Fixes UML-3394

Approach

Explain how your code addresses the purpose of the change

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about the Use a Lasting Power of Attorney service

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • New event_codes have been documented on the wiki page
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • I have added tests to prove my work
  • I have added welsh translation tags and updated translation files
  • I have run an accessibility tool on any pages I have made changes to and fixed any issues found
  • I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
  • The product team have tested these changes

@github-actions github-actions bot added php Pull requests that update Php code service-api labels Sep 17, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.57388% with 16 lines in your changes missing coverage. Please review.

Project coverage is 91.77%. Comparing base (38c7bd6) to head (461ed67).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../app/src/App/src/Service/JWT/JWSBuilderFactory.php 0.00% 5 Missing ⚠️
...p/src/App/src/DataAccess/ApiGateway/SiriusLpas.php 0.00% 4 Missing ⚠️
...app/src/App/src/Service/Lpa/CombinedLpaManager.php 96.42% 3 Missing ⚠️
.../src/App/src/DataAccess/ApiGateway/GenerateJWT.php 0.00% 1 Missing ⚠️
...vice-api/app/src/App/src/Service/Lpa/SiriusLpa.php 0.00% 1 Missing ⚠️
...nt/app/src/Common/src/Service/Lpa/ParseLpaData.php 92.30% 1 Missing ⚠️
...ront/app/src/Common/src/View/Twig/LpaExtension.php 94.73% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2782      +/-   ##
============================================
- Coverage     91.94%   91.77%   -0.17%     
+ Complexity     1779     1747      -32     
============================================
  Files           391      360      -31     
  Lines          8269     8172      -97     
============================================
- Hits           7603     7500     -103     
- Misses          649      655       +6     
  Partials         17       17
Flag Coverage Δ
use-an-lpa-admin 78.85% <ø> (ø)
use-an-lpa-api 97.11% <96.41%> (-0.21%) ⬇️
use-an-lpa-front 90.21% <97.36%> (-0.47%) ⬇️
Files with missing lines Coverage Δ
...rc/App/src/DataAccess/ApiGateway/DataStoreLpas.php 98.73% <100.00%> (-1.27%) ⬇️
...src/DataAccess/ApiGateway/DataStoreLpasFactory.php 100.00% <100.00%> (ø)
...src/DataAccess/ApiGateway/RequestSignerFactory.php 100.00% <100.00%> (ø)
...src/App/src/DataAccess/Repository/Response/Lpa.php 100.00% <100.00%> (ø)
...p/src/App/src/Entity/Casters/CastToCaseSubtype.php 100.00% <100.00%> (ø)
...c/Entity/Casters/CastToLifeSustainingTreatment.php 100.00% <100.00%> (ø)
...p/src/Entity/Casters/CastToWhenTheLpaCanBeUsed.php 100.00% <100.00%> (ø)
...App/src/Entity/Casters/ExtractAddressFieldFrom.php 100.00% <100.00%> (ø)
service-api/app/src/App/src/Entity/Lpa.php 100.00% <100.00%> (ø)
...e-api/app/src/App/src/Entity/LpaStore/LpaStore.php 92.50% <100.00%> (+1.59%) ⬆️
... and 38 more

... and 1 file with indirect coverage changes

@cooperaj cooperaj force-pushed the UML-3394-combined-lpa-manager branch from e8463a5 to 4aceb27 Compare September 20, 2024 15:47
@github-actions github-actions bot added the python Pull requests that update Python code label Sep 20, 2024
@cooperaj cooperaj force-pushed the UML-3394-combined-lpa-manager branch from 4aceb27 to 160dd89 Compare November 19, 2024 15:46
@cooperaj cooperaj force-pushed the UML-3394-combined-lpa-manager branch 2 times, most recently from 81e99c5 to 9c999ad Compare December 3, 2024 13:53
@cooperaj cooperaj force-pushed the UML-3394-combined-lpa-manager branch from 9c999ad to 736ae76 Compare December 13, 2024 18:10
@github-actions github-actions bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code service-front labels Dec 13, 2024
@github-actions github-actions bot added the docker Pull requests that update Docker code label Dec 16, 2024
@cooperaj cooperaj force-pushed the UML-3394-combined-lpa-manager branch 2 times, most recently from 9947fdf to 2d43361 Compare January 16, 2025 15:59
@cooperaj cooperaj marked this pull request as ready for review January 16, 2025 16:04
@cooperaj cooperaj requested a review from a team as a code owner January 16, 2025 16:04
@allenannom allenannom force-pushed the UML-3394-combined-lpa-manager branch from ee73097 to bbc931c Compare January 17, 2025 10:11
cooperaj and others added 18 commits January 17, 2025 14:37
@cooperaj
Managed to add this back in during conflict resolving.
b9a105a
@cooperaj
Clean up class variable usage
5a934b7
@cooperaj
Not really possible to break the rest of this down.
344c94d 
So one big commit :(
@cooperaj
Don't need a pipeline setup for a route that doesn't exist.
fcdce84
@cooperaj
Fixes to Casters and entities
5524f0a
@cooperaj
Final set of unit test fixes (before we start codecoverage work)
dcc0674
@nickdavis2001 @cooperaj
fix test broken by merge in of main
f57e951
@cooperaj
Use mock logger in place of Monolog instance
b19b2b1
@allenannom @cooperaj
UML-3394 updated frontend tests - fixed behat tests with feature flag…
63e45ef 
… enabled
@cooperaj
Fix up some merge issues.
aaaf483
@cooperaj
Fix FindActorInLpa tests
b85c214
@cooperaj
Tidy up route.php imports
02a11fc
@cooperaj
SiriusUid field not existent should be handled.
90170c3
@allenannom @cooperaj
UML-3394 fixed lint
78e8306
@allenannom @cooperaj
UML-3394 fixed broken test & PersonDataFormatterTest.php
259a016
@cooperaj
The waitforit application we use in seeding has changed ownership.
65f6041 
We can probably make this work much better if we just use docker-compose healthchecks instead.
@cooperaj
Ensure we handle modernise records in the DB when the combined format…
d84280a 
… flag is turned off.

This should, in reality, only affect the dev environments but it does break them if we don't.
@cooperaj
Code tidy ups after rebase
a2685c1
@cooperaj cooperaj force-pushed the UML-3394-combined-lpa-manager branch from 45a82eb to a2685c1 Compare January 17, 2025 14:55
nickdavis2001
nickdavis2001 approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@nickdavis2001 nickdavis2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@cooperaj cooperaj merged commit 858bba5 into main Jan 20, 2025
35 checks passed
@cooperaj cooperaj deleted the UML-3394-combined-lpa-manager branch January 20, 2025 11:59
cooperaj added a commit that referenced this pull request Jan 20, 2025
@cooperaj
Revert "Uml 3394 combined lpa manager (#2782)"
dca6d3b 
This reverts commit 858bba5.
@cooperaj cooperaj mentioned this pull request Jan 20, 2025
Merged
cooperaj added a commit that referenced this pull request Jan 20, 2025
@cooperaj
Revert "Uml 3394 combined lpa manager (#2782)" (#3076)
2a60894 
This reverts commit 858bba5.
@cooperaj cooperaj restored the UML-3394-combined-lpa-manager branch January 20, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickdavis2001 nickdavis2001 nickdavis2001 approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code javascript Pull requests that update Javascript code php Pull requests that update Php code python Pull requests that update Python code service-api service-front
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cooperaj @nickdavis2001 @allenannom